Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update composer.json #3

Merged
merged 1 commit into from
Oct 28, 2014
Merged

Update composer.json #3

merged 1 commit into from
Oct 28, 2014

Conversation

SerafimArts
Copy link
Contributor

Add binary

nervo added a commit that referenced this pull request Oct 28, 2014
@nervo nervo merged commit 89f7576 into nervo:master Oct 28, 2014
@nervo
Copy link
Owner

nervo commented Oct 28, 2014

Great idea !

@SerafimArts
Copy link
Contributor Author

What about extend this idea and add php class wrapper? =)
as example:

class Yui
{
  public static function compress($inputFile, $output)
  {
    exec('java -jar yuicompressor.jar ****** // etc
  }
}

@nervo
Copy link
Owner

nervo commented Oct 29, 2014

I would say it depends of your usage of yuicompressor. For instance, we used (i say "used", because we are now using npm packages for this) it with assetic, where you just have to declare the jar path.
I'm not against a wrapper, but with a more solid approach.
Things like a class named "YuiCompressor" instead of just "Yui", a compress method not static (so that you can pass some parameters to the constrcutor) ,an adapter system to allow usage of third party libraries like process (http://symfony.com/doc/current/components/process.html), a logger, etc...

@nervo
Copy link
Owner

nervo commented Oct 29, 2014

I'm curious : what is your usage of yuicompressor ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants